Add Gambit/OpenSpiel interoperability tutorial#573
Add Gambit/OpenSpiel interoperability tutorial#573edwardchalstrey1 merged 228 commits intomasterfrom
Conversation
…e server when doing local development to docs
…link to the team page
edwardchalstrey1
moved this from In progress
to In review
in Ed Chalstrey Gambit priorities
rahulsavani
left a comment
rahulsavani
left a comment
There was a problem hiding this comment.
Overall looks good, thanks, just some small suggestions to tighten up the language in a few places.
I would prefer "extensive-form game" and "normal-form game" with the hyphens, but I haven't checked if we are consistent with this elsewhere in the docs.
edwardchalstrey1
moved this from In review
to In progress
in Ed Chalstrey Gambit priorities
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks @rahulsavani these changes should now be made, you can see in the comment above that "ReviewNB" is now available. The OpenSpiel notebook doesn't show a diff since it's new, but you can see how it works by looking at the small change I applied to the other notebooks (hyphenating to "extensive-form" and "normal-form") which shows a clear diff which should make reviews for updates to tutorials easier going forward. |
edwardchalstrey1
moved this from In progress
to In review
in Ed Chalstrey Gambit priorities
|
Thanks @edwardchalstrey1, ReviewNB indeed seems nice and convenient. |
github-project-automation
bot
moved this from In review
to Done
in Ed Chalstrey Gambit priorities
3 participants
Closes #555
Includes changes from #621
See the tutorial here
and where it fits on the PyGambit docs pages here
Changes
.gitignore